Attempt to Create the Strategy for Mirror -UST #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chand mis and usdt to mir and ust
Changed to uniswap router from sushiswap
purperen
reviewed
Feb 5, 2021
| ); | ||
| _swapSushiswapWithPath(mis_usdt_path, _mis.sub(_keepMIS)); | ||
| _swapSushiswapWithPath(mir_ust_path, _mir.sub(_keepMIR)); |
There was a problem hiding this comment.
Here you are swapping MIR for UST, just below you are swapping half of UST for MIR.
So it would make more sense to here just swap half of MIR for UST and skip the second swap.
Save some gas :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passed my compile tests, but I wasn't able to test the interface.